[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tcg/optimize: Add fallthrough annotations
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] tcg/optimize: Add fallthrough annotations |
|
Date: |
Thu, 29 Oct 2020 13:07:07 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 10/29/20 5:28 AM, Thomas Huth wrote:
> To be able to compile this file with -Werror=implicit-fallthrough,
> we need to add some fallthrough annotations to the case statements
> that might fall through. Unfortunately, the typical "/* fallthrough */"
> comments do not work here as expected since some case labels are
> wrapped in macros and the compiler fails to match the comments in
> this case. But using __attribute__((fallthrough)) seems to work fine,
> so let's use that instead.
Why would the macro matter? It expands to two case statements with nothing in
between them.
This sounds like a compiler bug that should be reported.
r~