[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/8] target/ppc: replaced the TODO with LOG_UNIMP and add
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 8/8] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings |
Date: |
Fri, 30 Oct 2020 07:33:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/30/20 1:40 AM, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> target/ppc/mmu_helper.c: In function ‘dump_mmu’:
> target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 1351 | if (ppc64_v3_radix(env_archcpu(env))) {
> | ^
> target/ppc/mmu_helper.c:1358:5: note: here
> 1358 | default:
> | ^~~~~~~
>
> Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment.
> And add the break statement to fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> v1->v2: replace the TODO by a LOG_UNIMP call and add break statement(Base on
> Philippe's comments)
>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/ppc/mmu_helper.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> index 8972714775..12723362b7 100644
> --- a/target/ppc/mmu_helper.c
> +++ b/target/ppc/mmu_helper.c
> @@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env)
> break;
> case POWERPC_MMU_3_00:
> if (ppc64_v3_radix(env_archcpu(env))) {
> - /* TODO - Unsupported */
> + qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU unsupported\n",
> + __func__);
> } else {
> dump_slb(env_archcpu(env));
> - break;
> }
> + break;
> #endif
> default:
> qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__);
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v2 0/8] silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 1/8] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Chen Qun, 2020/10/29
- [PATCH v2 4/8] linux-user/mips/cpu_loop: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 3/8] accel/tcg/user-exec: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 2/8] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 8/8] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings, Chen Qun, 2020/10/29
- [PATCH v2 5/8] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 7/8] ppc: Add a missing break for PPC6xx_INPUT_TBEN, Chen Qun, 2020/10/29
- [PATCH v2 6/8] target/sparc/win_helper: silence the compiler warnings, Chen Qun, 2020/10/29