[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2] hw/rx/rx-gdbsim: Fix memory leak
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH-for-5.2] hw/rx/rx-gdbsim: Fix memory leak |
Date: |
Fri, 30 Oct 2020 08:21:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/29/20 8:57 PM, Richard Henderson wrote:
> On 10/28/20 12:22 PM, Philippe Mathieu-Daudé wrote:
>> + g_autofree void *dtb;
>>
>> dtb = load_device_tree(dtb_filename, &dtb_size);
>
> With g_autofree, we must initialize the variable on declaration. Often this
> is
> with NULL, but in this case, just merge these two lines.
OK.
>
> With that,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thanks!