qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg


From: Marc-André Lureau
Subject: Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg
Date: Fri, 30 Oct 2020 11:34:09 +0400



On Fri, Oct 30, 2020 at 11:29 AM Marc-André Lureau <marcandre.lureau@gmail.com> wrote:


On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost <ehabkost@redhat.com> wrote:
Make the code more generic and not specific to TYPE_DEVICE.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Nice cleanup!, but fails to build atm

../hw/block/xen-block.c:403:9: error: ‘dev’ undeclared (first use in this function); did you mean ‘vdev’?
  403 |     if (dev->realized) {


That seems to be the only issue though, so with that fixed:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]