[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/intc: Fix incorrect calculation of core in liointc_read()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] hw/intc: Fix incorrect calculation of core in liointc_read() and liointc_write() |
Date: |
Tue, 3 Nov 2020 13:28:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/3/20 10:32 AM, AlexChen wrote:
> According to the loongson spec
> (http://www.loongson.cn/uploadfile/cpu/3B1500/Loongson_3B1500_cpu_user_1.pdf)
> and the macro definition(#define R_PERCORE_ISR(x) (0x40 + 0x8 * x)), we know
> that the ISR size of per CORE is 8, so here we need to divide
> (addr - R_PERCORE_ISR(0)) by 8, not 4.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>
> ---
> hw/intc/loongson_liointc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
For a model added in 2020, its code style is a bit
disappointing (leading to that kind of hidden bugs).
I'm even surprised it passed the review process.
Thanks for the fix.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Re: [PATCH] hw/intc: Fix incorrect calculation of core in liointc_read() and liointc_write(), Philippe Mathieu-Daudé, 2020/11/03