qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/20] memfd: Remove unnecessary prefix from error message


From: Igor Mammedov
Subject: Re: [PATCH 10/20] memfd: Remove unnecessary prefix from error message
Date: Tue, 3 Nov 2020 13:30:23 +0100

On Fri, 30 Oct 2020 16:21:21 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:

> object_property_parse() will add a
>   "Property '<TYPE>.<PROP>' can't take value '<VALUE>'"
> prefix automatically for us.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
>  backends/hostmem-memfd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c
> index e5626d4330..05cf743fe8 100644
> --- a/backends/hostmem-memfd.c
> +++ b/backends/hostmem-memfd.c
> @@ -87,8 +87,7 @@ memfd_backend_set_hugetlbsize(Object *obj, Visitor *v, 
> const char *name,
>          return;
>      }
>      if (!value) {
> -        error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu64 "'",
> -                   object_get_typename(obj), name, value);
> +        error_setg(errp, "hugetlbsize can't be zero");
>          return;
>      }
>      m->hugetlbsize = value;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]