[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/20] i386: Remove unnecessary prefix from error message
From: |
Igor Mammedov |
Subject: |
Re: [PATCH 14/20] i386: Remove unnecessary prefix from error message |
Date: |
Tue, 3 Nov 2020 13:34:36 +0100 |
On Fri, 30 Oct 2020 16:21:25 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:
> object_property_parse() will add a
> "Property '<TYPE>.<PROP>' can't take value '<VALUE>'"
> prefix automatically for us.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 0d8606958e..2c00f94308 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -4529,7 +4529,7 @@ static void x86_cpuid_set_vendor(Object *obj, const
> char *value,
> int i;
>
> if (strlen(value) != CPUID_VENDOR_SZ) {
> - error_setg(errp, QERR_PROPERTY_VALUE_BAD, "", "vendor", value);
> + error_setg(errp, "invalid vendor ID");
> return;
> }
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 14/20] i386: Remove unnecessary prefix from error message,
Igor Mammedov <=