[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2 4/4] migration/ram: Fix hexadecimal format string spe
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH-for-5.2 4/4] migration/ram: Fix hexadecimal format string specifier |
Date: |
Tue, 3 Nov 2020 12:46:34 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> The '%u' conversion specifier is for decimal notation.
> When prefixing a format with '0x', we want the hexadecimal
> specifier ('%x').
>
> Inspired-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 2da2b622ab2..23dcfb3ac38 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -3729,7 +3729,7 @@ int ram_dirty_bitmap_reload(MigrationState *s, RAMBlock
> *block)
> }
>
> if (end_mark != RAMBLOCK_RECV_BITMAP_ENDING) {
> - error_report("%s: ramblock '%s' end mark incorrect: 0x%"PRIu64,
> + error_report("%s: ramblock '%s' end mark incorrect: 0x%"PRIx64,
> __func__, block->idstr, end_mark);
> ret = -EINVAL;
> goto out;
> --
> 2.26.2
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Re: [PATCH-for-5.2 0/4] misc: Trivial format string fixes, Dov Murik, 2020/11/03