[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2 v3] hw/mips: Remove the 'r4k' machine
From: |
Peter Krempa |
Subject: |
Re: [PATCH-for-5.2 v3] hw/mips: Remove the 'r4k' machine |
Date: |
Tue, 3 Nov 2020 14:14:55 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Mon, Nov 02, 2020 at 21:13:11 +0100, Philippe Mathieu-Daudé wrote:
> We deprecated the support for the 'r4k' machine for the 5.0 release
> (commit d32dc61421), which means that our deprecation policy allows
> us to drop it in release 5.2. Remove the code.
>
> To repeat the rationale from the deprecation note:
> - this virtual machine has no specification
> - the Linux kernel dropped support for it 10 years ago
>
> Users are recommended to use the Malta board instead.
>
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v3: Move to "Recently removed features" section
> ---
> docs/system/deprecated.rst | 12 +-
> .../devices/mips-softmmu-common.mak | 1 -
> hw/mips/r4k.c | 318 ------------------
> MAINTAINERS | 6 -
> hw/mips/Kconfig | 13 -
> hw/mips/meson.build | 1 -
> 6 files changed, 6 insertions(+), 345 deletions(-)
> delete mode 100644 hw/mips/r4k.c
To be honest, libvirt doesn't have a single mips-based VM definition in
the test-suite, so our mips support is rather theoretical.
On behalf of libvirt:
ACKed-by: Peter Krempa <pkrempa@redhat.com>