[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/11] sockets: Bypass "replace empty @path" for abstract unix soc
From: |
Daniel P . Berrangé |
Subject: |
[PULL 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets |
Date: |
Tue, 3 Nov 2020 14:02:24 +0000 |
From: Markus Armbruster <armbru@redhat.com>
unix_listen_saddr() replaces empty @path by unique value. It obtains
the value by creating and deleting a unique temporary file with
mkstemp(). This is racy, as the comment explains. It's also entirely
undocumented as far as I can tell. Goes back to commit d247d25f18
"sockets: helper functions for qemu (Gerd Hoffman)", v0.10.0.
Since abstract socket addresses have no connection with filesystem
pathnames, making them up with mkstemp() seems inappropriate. Bypass
the replacement of empty @path.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
util/qemu-sockets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index a578c434c2..671717499f 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -877,7 +877,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,
return -1;
}
- if (saddr->path && saddr->path[0]) {
+ if (saddr->path[0] || saddr->abstract) {
path = saddr->path;
} else {
const char *tmpdir = getenv("TMPDIR");
--
2.28.0
- [PULL 00/11] Sock next patches, Daniel P . Berrangé, 2020/11/03
- [PULL 02/11] test-util-sockets: Correct to set has_abstract, has_tight, Daniel P . Berrangé, 2020/11/03
- [PULL 01/11] test-util-sockets: Plug file descriptor leak, Daniel P . Berrangé, 2020/11/03
- [PULL 03/11] test-util-sockets: Clean up SocketAddress construction, Daniel P . Berrangé, 2020/11/03
- [PULL 04/11] test-util-sockets: Factor out test_socket_unix_abstract_one(), Daniel P . Berrangé, 2020/11/03
- [PULL 05/11] test-util-sockets: Synchronize properly, don't sleep(1), Daniel P . Berrangé, 2020/11/03
- [PULL 06/11] test-util-sockets: Test the complete abstract socket matrix, Daniel P . Berrangé, 2020/11/03
- [PULL 07/11] sockets: Fix default of UnixSocketAddress member @tight, Daniel P . Berrangé, 2020/11/03
- [PULL 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets, Daniel P . Berrangé, 2020/11/03
- [PULL 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets,
Daniel P . Berrangé <=
- [PULL 09/11] char-socket: Fix qemu_chr_socket_address() for abstract sockets, Daniel P . Berrangé, 2020/11/03
- [PULL 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX, Daniel P . Berrangé, 2020/11/03
- Re: [PULL 00/11] Sock next patches, Peter Maydell, 2020/11/03