qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user: Check copy_from_user() return value in vma_dump_


From: no-reply
Subject: Re: [PATCH] linux-user: Check copy_from_user() return value in vma_dump_size()
Date: Tue, 3 Nov 2020 06:22:18 -0800 (PST)

Patchew URL: 
20201103141532.19912-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20201103141532.19912-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201103141532.19912-1-peter.maydell@linaro.org
Subject: [PATCH] linux-user: Check copy_from_user() return value in 
vma_dump_size()

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
421265c linux-user: Check copy_from_user() return value in vma_dump_size()

=== OUTPUT BEGIN ===
ERROR: space prohibited between function name and open parenthesis '('
#26: FILE: linux-user/elfload.c:3487:
+        if (copy_from_user(page, vma->vma_start, sizeof (page))) {

total: 1 errors, 0 warnings, 10 lines checked

Commit 421265c84dcb (linux-user: Check copy_from_user() return value in 
vma_dump_size()) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201103141532.19912-1-peter.maydell@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20201103141532.19912-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

reply via email to

[Prev in Thread] Current Thread [Next in Thread]