Re: [PATCH] hw/arm/nseries: Check return value from load_image_targphys()

[Peter Maydell]

On Tue, 3 Nov 2020 at 21:00, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 11/3/20 12:49 PM, Peter Maydell wrote:
> > The nseries machines have a codepath that allows them to load a
> > secondary bootloader.  This code wasn't checking that the
> > load_image_targphys() succeeded.  Check the return value and report
> > the error to the user.
> >
> > While we're in the vicinity, fix the comment style of the
> > comment documenting what this image load is doing.
> >
> > Fixes: Coverity CID 1192904
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> What about the other cases?
>
> $ git grep -E ^\\s+load_image_targphys
> hw/alpha/dp264.c:163:            load_image_targphys(initrd_filename,
> initrd_base,
> hw/hppa/machine.c:301:            load_image_targphys(initrd_filename,
> initrd_base, initrd_size);
> hw/m68k/q800.c:388:            load_image_targphys(initrd_filename,
> initrd_base,

They could be fixed too, certainly; I only care about the ones
Coverity is currently complaining about, though :-)

-- PMM