[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 63/72] scripts/qmp-shell: remove TODO
From: |
John Snow |
Subject: |
[PATCH v2 63/72] scripts/qmp-shell: remove TODO |
Date: |
Tue, 3 Nov 2020 19:35:53 -0500 |
We still want to revamp qmp-shell again, but there's much more to the
idea than the comment now intuits. Remove it.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qmp/qmp-shell | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
index 0199a13a3428..3c32b576a37d 100755
--- a/scripts/qmp/qmp-shell
+++ b/scripts/qmp/qmp-shell
@@ -130,8 +130,6 @@ class FuzzyJSON(ast.NodeTransformer):
return node
-# TODO: QMPShell's interface is a bit ugly (eg. _fill_completion() and
-# _execute_cmd()). Let's design a better one.
class QMPShell(qmp.QEMUMonitorProtocol):
def __init__(self, address: qmp.SocketAddrT,
pretty: bool = False, verbose: bool = False):
--
2.26.2
- [PATCH v2 53/72] scripts/qmp-shell: Fix "FuzzyJSON" parser, (continued)
- [PATCH v2 53/72] scripts/qmp-shell: Fix "FuzzyJSON" parser, John Snow, 2020/11/03
- [PATCH v2 54/72] scripts/qmp-shell: refactor QMPCompleter, John Snow, 2020/11/03
- [PATCH v2 56/72] python/qmp: add QMPObject type alias, John Snow, 2020/11/03
- [PATCH v2 59/72] scripts/qmp-shell: unprivatize 'pretty' property, John Snow, 2020/11/03
- [PATCH v2 58/72] scripts/qmp-shell: Accept SocketAddrT instead of string, John Snow, 2020/11/03
- [PATCH v2 55/72] scripts/qmp-shell: initialize completer early, John Snow, 2020/11/03
- [PATCH v2 61/72] scripts/qmp-shell: Use context manager instead of atexit, John Snow, 2020/11/03
- [PATCH v2 62/72] scripts/qmp-shell: use logging to show warnings, John Snow, 2020/11/03
- [PATCH v2 65/72] scripts/qmp-shell: Remove too-broad-exception, John Snow, 2020/11/03
- [PATCH v2 66/72] scripts/qmp-shell: convert usage comment to docstring, John Snow, 2020/11/03
- [PATCH v2 63/72] scripts/qmp-shell: remove TODO,
John Snow <=
- [PATCH v2 64/72] scripts/qmp-shell: Fix empty-transaction invocation, John Snow, 2020/11/03
- [PATCH v2 57/72] scripts/qmp-shell: add mypy types, John Snow, 2020/11/03
- [PATCH v2 60/72] python/qmp: return generic type from context manager, John Snow, 2020/11/03
- [PATCH v2 68/72] scripts/qmp-shell: make QMPShellError inherit QMPError, John Snow, 2020/11/03
- [PATCH v2 67/72] scripts/qmp-shell: remove double-underscores, John Snow, 2020/11/03
- [PATCH v2 71/72] python: add qmp-shell entry point, John Snow, 2020/11/03
- [PATCH v2 69/72] scripts/qmp-shell: add docstrings, John Snow, 2020/11/03
- [PATCH v2 70/72] scripts/qmp-shell: move to python/qemu/qmp/qmp_shell.py, John Snow, 2020/11/03
- [PATCH v2 72/72] scripts/qmp-shell: add redirection shim, John Snow, 2020/11/03