[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH for-5.2 3/3] hw/block/nvme: fix free of array-typed value |
|
Date: |
Wed, 4 Nov 2020 12:10:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 04.11.20 12:04, Klaus Jensen wrote:
> On Nov 4 11:59, Max Reitz wrote:
>> On 04.11.20 11:22, Klaus Jensen wrote:
>>> From: Klaus Jensen <k.jensen@samsung.com>
>>>
>>> Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the
>>> namespaces member of NvmeCtrl is no longer a dynamically allocated
>>> array. Remove the free.
>>>
>>> Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces")
>>> Reported-by: Coverity (CID 1436131)
>>> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
>>> ---
>>> hw/block/nvme.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>
>> Thanks! :)
>>
>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>
>
> Will Peter pick up fixes like this directly so we don't have to go
> through a pull request from nvme-next?
AFAIA, Peter only picks up build fixes. Since the build wasn’t broken,
I think someone™ will have to send a pull request...
I understand you don’t necessarily want to be that someone, so I suppose
I might as well.
> Did I correctly annotate with "for-5.2"? :)
Yes!
Max