[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 27/44] qdev: Don't set qdev_prop_name for array elements
From: |
Eduardo Habkost |
Subject: |
[PATCH v2 27/44] qdev: Don't set qdev_prop_name for array elements |
Date: |
Wed, 4 Nov 2020 11:00:04 -0500 |
qdev_prop_name is supposed to be used only by qdev property
registration code, we don't need to set it for array element
properties.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
This is a new patch added in v2 of the series
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
hw/core/qdev-properties.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 5a4aa87fc9..f1557f12b9 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -596,7 +596,6 @@ static void set_prop_arraylen(Object *obj, Visitor *v,
const char *name,
arrayprop->release = prop->arrayinfo->release;
arrayprop->propname = propname;
arrayprop->prop.info = prop->arrayinfo;
- arrayprop->prop.qdev_prop_name = propname;
/* This ugly piece of pointer arithmetic sets up the offset so
* that when the underlying get/set hooks call qdev_get_prop_ptr
* they get the right answer despite the array element not actually
--
2.28.0
- [PATCH v2 21/44] qdev: Wrap getters and setters in separate helpers, (continued)
- [PATCH v2 21/44] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/11/04
- [PATCH v2 15/44] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/11/04
- [PATCH v2 28/44] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen(), Eduardo Habkost, 2020/11/04
- [PATCH v2 39/44] qdev: PROP_* macros, Eduardo Habkost, 2020/11/04
- [PATCH v2 32/44] qom: Add allow_set callback to ObjectProperty, Eduardo Habkost, 2020/11/04
- [PATCH v2 31/44] qdev: Reuse object_property_add_field() when adding array elements, Eduardo Habkost, 2020/11/04
- [PATCH v2 18/44] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/11/04
- [PATCH v2 22/44] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/11/04
- [PATCH v2 27/44] qdev: Don't set qdev_prop_name for array elements,
Eduardo Habkost <=
- [PATCH v2 29/44] qdev: Remove ArrayElementProperty.propname field, Eduardo Habkost, 2020/11/04
- [PATCH v2 40/44] qdev: Move core field property code to QOM, Eduardo Habkost, 2020/11/04
- [PATCH v2 23/44] qdev: Make PropertyInfo.create return ObjectProperty*, Eduardo Habkost, 2020/11/04
- [PATCH v2 26/44] qdev: Rename Property.name to Property.qdev_prop_name, Eduardo Habkost, 2020/11/04
- [PATCH v2 33/44] qdev: Make qdev_prop_allow_set() a ObjectProperty.allow_set callback, Eduardo Habkost, 2020/11/04
- [PATCH v2 41/44] qdev: Move base property types to qom/property-types.c, Eduardo Habkost, 2020/11/04
- [PATCH v2 34/44] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/11/04