[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_
From: |
Richard Henderson |
Subject: |
Re: [PATCH] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END" |
Date: |
Wed, 4 Nov 2020 10:27:45 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/4/20 10:12 AM, Peter Maydell wrote:
> On Tue, 3 Nov 2020 at 21:38, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> This reverts commit cd0372c515c4732d8bd3777cdd995c139c7ed7ea.
>>
>> The patch is incorrect in that it retains copies between globals and
>> non-local temps, and non-local temps still die at the end of the BB.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> I assume you're going to put this in a pullreq at some point
> before rc1?
Yep. I have one other bug fix as well.
r~