[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub |
|
Date: |
Thu, 5 Nov 2020 20:20:00 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/5/20 6:51 PM, Alex Bennée wrote:
> We should never build something that calls this without having it.
"because ..."?
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> stubs/xen-hw-stub.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c
> index 2ea8190921..15f3921a76 100644
> --- a/stubs/xen-hw-stub.c
> +++ b/stubs/xen-hw-stub.c
> @@ -10,10 +10,6 @@
> #include "hw/xen/xen.h"
> #include "hw/xen/xen-x86.h"
>
> -void xenstore_store_pv_console_info(int i, Chardev *chr)
> -{
> -}
> -
> int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num)
> {
> return -1;
>
- [RFC PATCH 08/15] meson.build: fix building of Xen support for aarch64, (continued)
- [RFC PATCH 08/15] meson.build: fix building of Xen support for aarch64, Alex Bennée, 2020/11/05
- [RFC PATCH 10/15] meson.build: clean-up summary reporting of XEN and it's features, Alex Bennée, 2020/11/05
- [RFC PATCH 09/15] meson.build: introduce CONFIG_XEN_HVM flag, Alex Bennée, 2020/11/05
- [RFC PATCH 07/15] accel/meson: you only need accelerator stubs for softmmu builds, Alex Bennée, 2020/11/05
- [RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub, Alex Bennée, 2020/11/05
- Re: [RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub,
Philippe Mathieu-Daudé <=
- [RFC PATCH 14/15] xen: only build HVM support under CONFIG_XEN_HVM, Alex Bennée, 2020/11/05
- [RFC PATCH 13/15] accel/stubs: drop unused cpu.h include, Alex Bennée, 2020/11/05
- [RFC PATCH 15/15] meson.build: build a Xen aware qemu-aarch64-system, Alex Bennée, 2020/11/05
- [RFC PATCH 11/15] include/hw/xen.h: drop superfluous struct, Alex Bennée, 2020/11/05
- Re: [RFC PATCH 00/15] Xen guest-loader and arm64 build fixes/enhancements, no-reply, 2020/11/05