Re: [PATCH 1/1] Change the order of g_free(info) and tracepoint

[David Edmondson]

On Friday, 2020-11-06 at 19:09:24 +0530, Kirti Wankhede wrote:

> Fixes Coverity issue:
> CID 1436126:  Memory - illegal accesses  (USE_AFTER_FREE)
>
> Fixes: a9e271ec9b36 ("vfio: Add migration region initialization and finalize
> function")
>
> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>

Maybe "fix use after free in vfio_migration_probe" as a summary?

Reviewed-by: David Edmondson <dme@dme.org>

> ---
>  hw/vfio/migration.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
> index 3ce285ea395d..55261562d4f3 100644
> --- a/hw/vfio/migration.c
> +++ b/hw/vfio/migration.c
> @@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error 
> **errp)
>          goto add_blocker;
>      }
>  
> -    g_free(info);
>      trace_vfio_migration_probe(vbasedev->name, info->index);
> +    g_free(info);
>      return 0;
>  
>  add_blocker:
> -- 
> 2.7.0

dme.
-- 
I think I waited too long, I'm moving into the dollhouse.