qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel out


From: Paolo Bonzini
Subject: Re: [PATCH] meson: Clarify the confusing vhost-user vs. vhost-kernel output
Date: Mon, 9 Nov 2020 10:09:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 09/11/20 09:59, Thomas Huth wrote:
The configuration summary prints a line with "vhost-user: YES/NO",
but the value is currently the vhost-kernel setting instead which
looks wrong. Print the kernel setting in a separate line and switch
the "vhost-user:" line to CONFIG_VHOST_USER instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  meson.build | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index b473620321..61d883bc07 100644
--- a/meson.build
+++ b/meson.build
@@ -2098,11 +2098,12 @@ summary_info += {'madvise':           
config_host.has_key('CONFIG_MADVISE')}
  summary_info += {'posix_madvise':     
config_host.has_key('CONFIG_POSIX_MADVISE')}
  summary_info += {'posix_memalign':    
config_host.has_key('CONFIG_POSIX_MEMALIGN')}
  summary_info += {'libcap-ng support': config_host.has_key('CONFIG_LIBCAP_NG')}
+summary_info += {'vhost-kernel support': 
config_host.has_key('CONFIG_VHOST_KERNEL')}
  summary_info += {'vhost-net support': config_host.has_key('CONFIG_VHOST_NET')}
  summary_info += {'vhost-crypto support': 
config_host.has_key('CONFIG_VHOST_CRYPTO')}
  summary_info += {'vhost-scsi support': 
config_host.has_key('CONFIG_VHOST_SCSI')}
  summary_info += {'vhost-vsock support': 
config_host.has_key('CONFIG_VHOST_VSOCK')}
-summary_info += {'vhost-user support': 
config_host.has_key('CONFIG_VHOST_KERNEL')}
+summary_info += {'vhost-user support': 
config_host.has_key('CONFIG_VHOST_USER')}
  summary_info += {'vhost-user-fs support': 
config_host.has_key('CONFIG_VHOST_USER_FS')}
  summary_info += {'vhost-vdpa support': 
config_host.has_key('CONFIG_VHOST_VDPA')}
  summary_info += {'Trace backends':    config_host['TRACE_BACKENDS']}


Queued, thanks.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]