qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v5] introduce vfio-user protocol specification


From: Thanos Makatos
Subject: RE: [PATCH v5] introduce vfio-user protocol specification
Date: Mon, 9 Nov 2020 09:20:01 +0000

> > >   * *Error* in a reply message indicates the command being
> acknowledged
> > had
> > >     an error. In this case, the *Error* field will be valid.
> > >
> > > * *Error* in a reply message is a UNIX errno value. It is reserved in a
> > command message.
> >
> > I'm not quite following why we need a bit flag and an error field. Do you
> > anticipate a failure, but with errno==0?
> 
> Indeed, the Error bit seems redundant. John, is there a reason why we need
> the
> error bit?

I haven't heard back from John yet; however I think it makes sense to maintain
an error bit and not necessarily require errno to be set, since there can be
errors that no errno value makes sense. I'll update the spec.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]