[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover
From: |
Thomas Huth |
Subject: |
Re: [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options |
Date: |
Mon, 9 Nov 2020 11:16:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
> Add these missing options to the 'build-disabled' job:
> --disable-auth-pam (commit 8953caf3cd38)
> --disable-gcrypt (commit 91bfcdb01d48)
> --disable-keyring (commit 54e7aac05624)
> --disable-libudev (commit 5c53015a480b)
> --disable-opengl (commit da076ffed6b9)
> --disable-sparse (commit 03b4fe7de226)
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.yml | 7 +++++++
> 1 file changed, 7 insertions(+)
[...]
> @@ -258,6 +264,7 @@ build-disabled:
> --disable-vhost-net
> --disable-vhost-scsi
> --disable-vhost-user
> + --disable-vhost-user-blk-server
> --disable-vhost-vdpa
> --disable-vhost-vsock
> --disable-virglrenderer
vhost-user-blk-server should get automatically disabled by
--disable-vhost-user ... so maybe drop this hunk, so that we're able to
detect problems with this logic in the future, too? (as we've just seen with
the current build failures in the CI)
... if you insist on keeping this hunk, I think you should at least mention
it in the patch description (since you've mentioned all the other options there)
Thomas
- [PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server, (continued)
- [PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server, Philippe Mathieu-Daudé, 2020/11/08
- [PATCH-for-5.2 v4 02/17] meson: always include contrib/libvhost-user, Philippe Mathieu-Daudé, 2020/11/08
- [PATCH-for-5.2 v4 03/17] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off, Philippe Mathieu-Daudé, 2020/11/08
- [PATCH-for-6.0 v4 04/17] MAINTAINERS: Add gitlab-pipeline-status script to GitLab CI section, Philippe Mathieu-Daudé, 2020/11/08
- [PATCH-for-6.0 v4 05/17] gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled, Philippe Mathieu-Daudé, 2020/11/08
- [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options, Philippe Mathieu-Daudé, 2020/11/08
- Re: [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options,
Thomas Huth <=
- [PATCH-for-6.0 v4 07/17] gitlab-ci: Move job testing --without-default-devices across to gitlab, Philippe Mathieu-Daudé, 2020/11/08
- Re: [PATCH-for-6.0 v4 07/17] gitlab-ci: Move job testing --without-default-devices across to gitlab, Wainer dos Santos Moschetta, 2020/11/10
[PATCH-for-6.0 v4 08/17] gitlab-ci: Move linux-user debug-tcg test across to gitlab, Philippe Mathieu-Daudé, 2020/11/08