|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 1/3] accel: Only include TCG stubs in user-mode only builds |
Date: | Mon, 9 Nov 2020 11:48:42 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 09/11/20 10:55, Claudio Fontana wrote:
Ciao Philippe, I thought that the pattern used by Paolo was, recurse always, and put the check inside the recursed dir meson.build . Paolo did you indeed intend meson use this way?
Generally yeah, I preferred to recurse always. In this specific case, however, an even bigger qualm with the patch is that the patch content does not match the commit message.
I also don't understand why it's useful, because patch 2 makes everything conditional on CONFIG_SOFTMMU.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |