Re: [PATCH v2 2/2] docs/fuzz: update make and run command lines

[Alexander Bulekov]

On 201109 1320, Thomas Huth wrote:
> On 09/11/2020 12.25, Dima Stepanov wrote:
> > After meson and some other build changes the qemu fuzz target should be
> > build as:
> >   make qemu-fuzz-i386
> > And also update the run path command line.
> > 
> > Signed-off-by: Dima Stepanov <dimastep@yandex-team.ru>
> > Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
> > ---
> >  docs/devel/fuzzing.txt | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/docs/devel/fuzzing.txt b/docs/devel/fuzzing.txt
> > index 03585c1..590900c 100644
> > --- a/docs/devel/fuzzing.txt
> > +++ b/docs/devel/fuzzing.txt
> > @@ -32,15 +32,15 @@ such as out-of-bounds accesses, use-after-frees, 
> > double-frees etc.
> >  
> >  Fuzz targets are built similarly to system/softmmu:
> >  
> > -    make i386-softmmu/fuzz
> > +    make qemu-fuzz-i386
> >  
> > -This builds ./i386-softmmu/qemu-fuzz-i386
> > +This builds ./build/qemu-fuzz-i386
> >  
> >  The first option to this command is: --fuzz-target=FUZZ_NAME
> >  To list all of the available fuzzers run qemu-fuzz-i386 with no arguments.
> >  
> >  For example:
> > -    ./i386-softmmu/qemu-fuzz-i386 --fuzz-target=virtio-scsi-fuzz
> > +    ./build/qemu-fuzz-i386 --fuzz-target=virtio-scsi-fuzz
> >  
> >  Internally, libfuzzer parses all arguments that do not begin with "--".
> >  Information about these is available by passing -help=1
> 
> This conflicts with Alexander's "docs/fuzz: update fuzzing documentation
> post-meson" patch ... which one should be used? One is better for people who
> do in-tree builds, the other is better for people who do out-of-tree builds

Ah my bad - I forgot that Dima also sent in fixes to these instructions.

> ... I'll go with Alexander's version for now for my next pull-request, since
> the text in this file says "/path/to/configure" which rather indicate
> out-of-tree builds, but in the long run, it would maybe be good to add some
> clarifying sentences here...
> 

Sounds good - I'll add more context/clarification to these instructions
later.

- Alex

>  Thomas
> 
>