[Bug 1734474] Re: Maemo does not boot on emulated N800

[Peter Maydell]

This change on current head-of-git, which is effectively just reverting the 
logic-change part of commit cb5ef3fa1871522a08, is sufficient to allow the n800 
image to boot again. 
But that commit was trying to fix a bug, so we probably need to look more 
carefully at the logic rather than just reverting it...

diff --git a/hw/misc/tmp105.c b/hw/misc/tmp105.c
index b47120492a..1813477268 100644
--- a/hw/misc/tmp105.c
+++ b/hw/misc/tmp105.c
@@ -161,14 +161,12 @@ static int tmp105_tx(I2CSlave *i2c, uint8_t data)
 {
     TMP105State *s = TMP105(i2c);
 
-    if (s->len == 0) {
+    if (!s->len++) {
         s->pointer = data;
-        s->len++;
     } else {
         if (s->len <= 2) {
             s->buf[s->len - 1] = data;
         }
-        s->len++;
         tmp105_write(s);
     }

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1734474

Title:
  Maemo does not boot on emulated N800

Status in QEMU:
  Confirmed

Bug description:
  I start QEMU with qemu-system-arm-m 130 -M n800 -kernel zImage.1 -mtdblock 
maemo.img -append "root=/dev/mtdblock3 rootfstype=jffs2"
  On QEMU 1.2.0 see "NOKIA" logo and then desktop appears, but on 1.5.0 and 
newer (including latest versions) I see only white screen and no signs of life. 
Was this caused by regression or any syntax change?

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1734474/+subscriptions