Re: [PATCH-for-6.0 v4 07/17] gitlab-ci: Move job testing --without-default-devices across to gitlab

[Philippe Mathieu-Daudé]

On 11/10/20 2:44 PM, Wainer dos Santos Moschetta wrote:
> 
> On 11/8/20 6:45 PM, Philippe Mathieu-Daudé wrote:
>> Similarly to commit 8cdb2cef3f1, move the job testing the
>> '--without-default-devices' configure option to GitLab.
>>
>> Since building all softmmu targets takes too long, split
>> the job in 2.
>>
>> As smoke test, run the qtests on the AVR and m68k targets.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>
>> v3 had:
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>> ---
>>   .gitlab-ci.yml | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>>   .travis.yml    |  8 --------
>>   2 files changed, 46 insertions(+), 8 deletions(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index b98800462ed..3fc3d0568c6 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -315,6 +315,52 @@ build-user-plugins:
>>       MAKE_CHECK_ARGS: check-tcg
>>     timeout: 1h 30m
>>   +build-system-ubuntu-without-default-devices 1/2:
> 
> Nit: It seems a non-usual key naming. Maybe
> "build-system-ubuntu-without-default-devices_1_2"  instead.

This is the GitLab convention:
https://docs.gitlab.com/ee/ci/pipelines/#group-jobs-in-a-pipeline

 This regular expression evaluates the job
 names: \d+[\s:\/\\]+\d+\s*.

I'll add a comment about it, but I don't think we should each
time we use the convention.

Thanks,

Phil.