[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 02/10] plugins: Fix two resource leaks in setup_socket()
From: |
Alex Bennée |
Subject: |
[PATCH v1 02/10] plugins: Fix two resource leaks in setup_socket() |
Date: |
Tue, 10 Nov 2020 19:23:08 +0000 |
From: Alex Chen <alex.chen@huawei.com>
Either accept() fails or exits normally, we need to close the fd.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Message-Id: <20201109082829.87496-3-alex.chen@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
contrib/plugins/lockstep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@ static bool setup_socket(const char *path)
socket_fd = accept(fd, NULL, NULL);
if (socket_fd < 0 && errno != EINTR) {
perror("accept socket");
+ close(fd);
return false;
}
qemu_plugin_outs("setup_socket::ready\n");
+ close(fd);
return true;
}
--
2.20.1
- [PATCH v1 for 5.1 00/10] various fixes (CI, Xen, plugins), Alex Bennée, 2020/11/10
- [PATCH v1 01/10] plugins: Fix resource leak in connect_socket(), Alex Bennée, 2020/11/10
- [PATCH v1 02/10] plugins: Fix two resource leaks in setup_socket(),
Alex Bennée <=
- [PATCH v1 04/10] include/hw/xen.h: drop superfluous struct, Alex Bennée, 2020/11/10
- [PATCH v1 03/10] meson.build: fix building of Xen support for aarch64, Alex Bennée, 2020/11/10
- [PATCH v1 05/10] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub, Alex Bennée, 2020/11/10
- [PATCH v1 07/10] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off, Alex Bennée, 2020/11/10
- [PATCH v1 08/10] tests/acceptance: Disable Spartan-3A DSP 1800A test, Alex Bennée, 2020/11/10
- [PATCH v1 06/10] accel/stubs: drop unused cpu.h include, Alex Bennée, 2020/11/10
- [PATCH v1 09/10] gitlab: move remaining x86 check-tcg targets to gitlab, Alex Bennée, 2020/11/10
- [PATCH v1 10/10] scripts/ci: clean up default args logic a little, Alex Bennée, 2020/11/10
- Re: [PATCH v1 for 5.1 00/10] various fixes (CI, Xen, plugins), Alex Bennée, 2020/11/10