Re: [PATCH] vl, qemu-config: remove -set

[Paolo Bonzini]

On 11/11/20 16:03, Daniel P. Berrangé wrote:
> iotest 068 uses -set and qtest vhost-user-text.c also does
>
> IOW, it looks like it is valid to use -set, even if you're not using
> -readconfig.
>
> Libvirt doesn't use -set, but we've had users who make use of libvirt
> command line passthrough for QEMU with -set.

Hmm, indeed:

https://patchwork.kernel.org/project/qemu-devel/patch/20181218041625.24969-16-mst@redhat.com/

> IOW, I'm not convinced real world usage is near zero as suggested.

Yes, perhaps it's not. :)  Though for both tests you pointed out it's 
even cleaner not to use it, there seems to be real world usage at least 
with "device".

It is probably more viable to deprecate or even forbid usage of "-set" 
with anything but "device".  vhost-user-test.c would still be affected, 
but it's a relatively small patch.

Paolo