[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] ads7846: put it into the 'display' category
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 2/4] ads7846: put it into the 'display' category |
Date: |
Thu, 12 Nov 2020 11:19:49 +0000 |
On Thu, 12 Nov 2020 at 07:25, Gan Qixin <ganqixin@huawei.com> wrote:
>
> The category of the ads7846 device is not set, put it into the 'display'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> hw/display/ads7846.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
> index 023165b2a3..b455cb5acd 100644
> --- a/hw/display/ads7846.c
> +++ b/hw/display/ads7846.c
> @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
>
> static void ads7846_class_init(ObjectClass *klass, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(klass);
> SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
>
> k->realize = ads7846_realize;
> k->transfer = ads7846_transfer;
> + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> }
This isn't a display, despite being in hw/display. It's a
touch-screen controller, so it ought to be in hw/input
and be DEVICE_CATEGORY_INPUT.
thanks
-- PMM