[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/11] migration/multifd: fix hangup with TLS-Multifd due to block
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 03/11] migration/multifd: fix hangup with TLS-Multifd due to blocking handshake |
Date: |
Thu, 12 Nov 2020 18:37:50 +0000 |
From: Chuan Zheng <zhengchuan@huawei.com>
The qemu main loop could hang up forever when we enable TLS+Multifd.
The Src multifd_send_0 invokes tls handshake, it sends hello to sever
and wait response.
However, the Dst main qemu loop has been waiting recvmsg() for multifd_recv_1.
Both of Src and Dst main qemu loop are blocking and waiting for reponse which
results in hanging up forever.
Src: (multifd_send_0) Dst:
(multifd_recv_1)
multifd_channel_connect
migration_channel_process_incoming
multifd_tls_channel_connect
migration_tls_channel_process_incoming
multifd_tls_channel_connect
qio_channel_tls_handshake_task
qio_channel_tls_handshake
gnutls_handshake
qio_channel_tls_handshake_task
...
qcrypto_tls_session_handshake
...
gnutls_handshake
...
...
...
recvmsg (Blocking I/O waiting for response)
recvmsg (Blocking I/O waiting for response)
Fix this by offloadinig handshake work to a background thread.
Reported-by: Yan Jin <jinyan12@huawei.com>
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Message-Id: <1604643893-8223-1-git-send-email-zhengchuan@huawei.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/multifd.c | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 68b171fb61..88486b90d6 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -739,6 +739,19 @@ static void multifd_tls_outgoing_handshake(QIOTask *task,
multifd_channel_connect(p, ioc, err);
}
+static void *multifd_tls_handshake_thread(void *opaque)
+{
+ MultiFDSendParams *p = opaque;
+ QIOChannelTLS *tioc = QIO_CHANNEL_TLS(p->c);
+
+ qio_channel_tls_handshake(tioc,
+ multifd_tls_outgoing_handshake,
+ p,
+ NULL,
+ NULL);
+ return NULL;
+}
+
static void multifd_tls_channel_connect(MultiFDSendParams *p,
QIOChannel *ioc,
Error **errp)
@@ -754,12 +767,10 @@ static void multifd_tls_channel_connect(MultiFDSendParams
*p,
trace_multifd_tls_outgoing_handshake_start(ioc, tioc, hostname);
qio_channel_set_name(QIO_CHANNEL(tioc), "multifd-tls-outgoing");
- qio_channel_tls_handshake(tioc,
- multifd_tls_outgoing_handshake,
- p,
- NULL,
- NULL);
-
+ p->c = QIO_CHANNEL(tioc);
+ qemu_thread_create(&p->thread, "multifd-tls-handshake-worker",
+ multifd_tls_handshake_thread, p,
+ QEMU_THREAD_JOINABLE);
}
static bool multifd_channel_connect(MultiFDSendParams *p,
--
2.28.0
- [PULL 00/11] migration queue, Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 01/11] migration/ram: Fix hexadecimal format string specifier, Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 02/11] ACPI: Avoid infinite recursion when dump-vmstate, Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 03/11] migration/multifd: fix hangup with TLS-Multifd due to blocking handshake,
Dr. David Alan Gilbert (git) <=
- [PULL 04/11] migration: fix uninitialized variable warning in migrate_send_rp_req_pages(), Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 05/11] migration/dirtyrate: simplify includes in dirtyrate.c, Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 06/11] multifd/tls: fix memoryleak of the QIOChannelSocket object when cancelling migration, Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 08/11] virtiofsd: Announce submounts even without statx(), Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 07/11] migration: handle CANCELLING state in migration_completion(), Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 09/11] tools/virtiofsd/buffer.c: check whether buf is NULL in fuse_bufvec_advance func, Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 10/11] virtiofsd: check whether lo_map_reserve returns NULL in, main func, Dr. David Alan Gilbert (git), 2020/11/12
- [PULL 11/11] virtiofsd: check whether strdup lo.source return NULL in main func, Dr. David Alan Gilbert (git), 2020/11/12
- Re: [PULL 00/11] migration queue, Peter Maydell, 2020/11/13