[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 10/53] qdev: Make qdev_find_global_prop() get Object* argument
From: |
Eduardo Habkost |
Subject: |
[PATCH v3 10/53] qdev: Make qdev_find_global_prop() get Object* argument |
Date: |
Thu, 12 Nov 2020 16:43:07 -0500 |
Make the code more generic and not specific to TYPE_DEVICE.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
include/hw/qdev-properties.h | 2 +-
hw/core/qdev-properties-system.c | 2 +-
hw/core/qdev-properties.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 0b92cfc761..7620095fed 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -305,7 +305,7 @@ void qdev_prop_set_enum(DeviceState *dev, const char *name,
int value);
void *qdev_get_prop_ptr(Object *obj, Property *prop);
void qdev_prop_register_global(GlobalProperty *prop);
-const GlobalProperty *qdev_find_global_prop(DeviceState *dev,
+const GlobalProperty *qdev_find_global_prop(Object *obj,
const char *name);
int qdev_prop_check_globals(void);
void qdev_prop_set_globals(DeviceState *dev);
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index c8c73c371b..af1339e562 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -36,7 +36,7 @@ static bool check_prop_still_unset(DeviceState *dev, const
char *name,
const void *old_val, const char *new_val,
Error **errp)
{
- const GlobalProperty *prop = qdev_find_global_prop(dev, name);
+ const GlobalProperty *prop = qdev_find_global_prop(OBJECT(dev), name);
if (!old_val) {
return true;
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 0a54a922c8..41482d83d1 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -818,7 +818,7 @@ void qdev_prop_register_global(GlobalProperty *prop)
g_ptr_array_add(global_props(), prop);
}
-const GlobalProperty *qdev_find_global_prop(DeviceState *dev,
+const GlobalProperty *qdev_find_global_prop(Object *obj,
const char *name)
{
GPtrArray *props = global_props();
@@ -827,7 +827,7 @@ const GlobalProperty *qdev_find_global_prop(DeviceState
*dev,
for (i = 0; i < props->len; i++) {
p = g_ptr_array_index(props, i);
- if (object_dynamic_cast(OBJECT(dev), p->driver)
+ if (object_dynamic_cast(obj, p->driver)
&& !strcmp(p->property, name)) {
return p;
}
--
2.28.0
- [PATCH v3 00/53] Make qdev static property API usable by any QOM type, Eduardo Habkost, 2020/11/12
- [PATCH v3 01/53] cs4231: Get rid of empty property array, Eduardo Habkost, 2020/11/12
- [PATCH v3 02/53] cpu: Move cpu_common_props to hw/core/cpu.c, Eduardo Habkost, 2020/11/12
- [PATCH v3 03/53] qdev: Move property code to qdev-properties.[ch], Eduardo Habkost, 2020/11/12
- [PATCH v3 04/53] qdev: Check dev->realized at set_size(), Eduardo Habkost, 2020/11/12
- [PATCH v3 08/53] qdev: Make bit_prop_set() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 07/53] qdev: Make PropertyInfo.print method get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 05/53] sparc: Check dev->realized at sparc_set_nwindows(), Eduardo Habkost, 2020/11/12
- [PATCH v3 06/53] qdev: Don't use dev->id on set_size32() error message, Eduardo Habkost, 2020/11/12
- [PATCH v3 10/53] qdev: Make qdev_find_global_prop() get Object* argument,
Eduardo Habkost <=
- [PATCH v3 11/53] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg, Eduardo Habkost, 2020/11/12
- [PATCH v3 12/53] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 13/53] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/11/12
- [PATCH v3 14/53] qdev: Move UUID property to qdev-properties-system.c, Eduardo Habkost, 2020/11/12
- [PATCH v3 17/53] sparc: Use DEFINE_PROP for nwindows property, Eduardo Habkost, 2020/11/12
- [PATCH v3 16/53] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/11/12
- [PATCH v3 15/53] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/11/12