[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/10] Tweak a few "Parameter 'NAME' expects THING" error message
From: |
Markus Armbruster |
Subject: |
[PATCH 10/10] Tweak a few "Parameter 'NAME' expects THING" error message |
Date: |
Fri, 13 Nov 2020 09:26:26 +0100 |
Change to "expects a THING" where that's an obvious improvement
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
block/quorum.c | 2 +-
blockdev.c | 2 +-
chardev/char.c | 2 +-
hw/core/qdev-properties-system.c | 2 +-
softmmu/qdev-monitor.c | 4 ++--
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/quorum.c b/block/quorum.c
index e846a7e892..656a80f93a 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -856,7 +856,7 @@ static int quorum_valid_threshold(int threshold, int
num_children, Error **errp)
if (threshold < 1) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
- "vote-threshold", "value >= 1");
+ "vote-threshold", "a value >= 1");
return -ERANGE;
}
diff --git a/blockdev.c b/blockdev.c
index d05a8740f4..6c7be7c522 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2991,7 +2991,7 @@ static void blockdev_mirror_common(const char *job_id,
BlockDriverState *bs,
}
if (granularity & (granularity - 1)) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "granularity",
- "power of 2");
+ "a power of 2");
return;
}
diff --git a/chardev/char.c b/chardev/char.c
index aa4282164a..a9b8c5a9aa 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -521,7 +521,7 @@ static const ChardevClass *char_get_class(const char
*driver, Error **errp)
if (object_class_is_abstract(oc)) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver",
- "abstract device type");
+ "an abstract device type");
return NULL;
}
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index b81a4e8d14..93061b5bf1 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -776,7 +776,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, const
char *name,
}
if (value < -1 || value > 255) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
- name ? name : "null", "pci_devfn");
+ name ? name : "null", "a value between -1 and 255");
return;
}
*ptr = value;
diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
index bcfb90a08f..08318c5d9d 100644
--- a/softmmu/qdev-monitor.c
+++ b/softmmu/qdev-monitor.c
@@ -237,7 +237,7 @@ static DeviceClass *qdev_get_device_class(const char
**driver, Error **errp)
if (object_class_is_abstract(oc)) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver",
- "non-abstract device type");
+ "a non-abstract device type");
return NULL;
}
@@ -245,7 +245,7 @@ static DeviceClass *qdev_get_device_class(const char
**driver, Error **errp)
if (!dc->user_creatable ||
(qdev_hotplug && !dc->hotpluggable)) {
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "driver",
- "pluggable device type");
+ "a pluggable device type");
return NULL;
}
--
2.26.2
- [PATCH 00/10] Chipping away at qerror.h, Markus Armbruster, 2020/11/13
- [PATCH 01/10] qerror: Drop unused QERR_ macros, Markus Armbruster, 2020/11/13
- [PATCH 03/10] block: Improve some block-commit, block-stream error messages, Markus Armbruster, 2020/11/13
- [PATCH 02/10] qerror: Eliminate QERR_ macros used in just one place, Markus Armbruster, 2020/11/13
- [PATCH 09/10] qom: Improve {qom, device}-list-properties error messages, Markus Armbruster, 2020/11/13
- [PATCH 10/10] Tweak a few "Parameter 'NAME' expects THING" error message,
Markus Armbruster <=
- [PATCH 08/10] qga: Tweak a guest-shutdown error message, Markus Armbruster, 2020/11/13
- [PATCH 05/10] ui: Improve a client_migrate_info error message, Markus Armbruster, 2020/11/13
- [PATCH 06/10] ui: Tweak a client_migrate_info error message, Markus Armbruster, 2020/11/13
- [PATCH 07/10] qga: Replace an unreachable error by abort(), Markus Armbruster, 2020/11/13
- [PATCH 04/10] ui: Improve some set_passwd, expire_password error messages, Markus Armbruster, 2020/11/13