Re: [PATCH] tests: add prefixes to the bare mkdtemp calls

[no-reply]

Patchew URL: 
20201113133424.8723-1-alex.bennee@linaro.org/">https://patchew.org/QEMU/20201113133424.8723-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20201113133424.8723-1-alex.bennee@linaro.org
Type: series
Subject: [PATCH] tests: add prefixes to the bare mkdtemp calls

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201113082626.2725812-1-armbru@redhat.com -> 
patchew/20201113082626.2725812-1-armbru@redhat.com
 * [new tag]         patchew/20201113133424.8723-1-alex.bennee@linaro.org -> 
patchew/20201113133424.8723-1-alex.bennee@linaro.org
Switched to a new branch 'test'
0a6d11e tests: add prefixes to the bare mkdtemp calls

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#23: FILE: python/qemu/machine.py:306:
+        self._temp_dir = tempfile.mkdtemp(prefix="qemu-machine-", 
dir=self._test_dir)

ERROR: line over 90 characters
#36: FILE: tests/acceptance/avocado_qemu/__init__.py:174:
+        vm = QEMUMachine(self.qemu_bin, 
sock_dir=tempfile.mkdtemp(prefix="avocado_qemu_sock_"))

total: 1 errors, 1 warnings, 16 lines checked

Commit 0a6d11e02824 (tests: add prefixes to the bare mkdtemp calls) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201113133424.8723-1-alex.bennee@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20201113133424.8723-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com