[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs
From: |
Daniel P . Berrangé |
Subject: |
Re: [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs |
Date: |
Fri, 13 Nov 2020 17:45:57 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Fri, Nov 13, 2020 at 05:44:04PM +0000, Alex Bennée wrote:
> We don't need running commentary for the CI logs and by keeping it
> short we might just see the problem on the first page. While we are at
> it flush the previous line so order is maintained between script and
> sub process.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.d/check-patch.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py
> index 0ff30ee077..39e2b403c9 100755
> --- a/.gitlab-ci.d/check-patch.py
> +++ b/.gitlab-ci.d/check-patch.py
> @@ -45,9 +45,9 @@ if log == "":
>
> errors = False
>
> -print("\nChecking all commits since %s...\n" % ancestor)
> +print("\nChecking all commits since %s...\n" % ancestor, flush=True)
>
> -ret = subprocess.run(["scripts/checkpatch.pl", ancestor + "..."])
> +ret = subprocess.run(["scripts/checkpatch.pl", "--terse", ancestor + "..."])
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|