[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/17] configure: mark vhost-user Linux-only
From: |
Michael S. Tsirkin |
Subject: |
[PULL 04/17] configure: mark vhost-user Linux-only |
Date: |
Sun, 15 Nov 2020 17:27:18 -0500 |
From: Stefan Hajnoczi <stefanha@redhat.com>
The vhost-user protocol uses the Linux eventfd feature and is typically
connected to Linux kvm.ko ioeventfd and irqfd file descriptors. The
protocol specification in docs/interop/vhost-user.rst does not describe
how platforms without eventfd support work.
The QEMU vhost-user devices compile on other POSIX host operating
systems because eventfd usage is abstracted in QEMU. The libvhost-user
programs in contrib/ do not compile but we failed to notice since they
are not built by default.
Make it clear that vhost-user is only supported on Linux for the time
being. If someone wishes to support it on other platforms then the
details can be added to vhost-user.rst and CI jobs can test the feature
to prevent bitrot.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20201110171121.1265142-4-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
configure | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 516f28a088..3fbc2a0c68 100755
--- a/configure
+++ b/configure
@@ -328,7 +328,7 @@ vhost_net=""
vhost_crypto=""
vhost_scsi=""
vhost_vsock=""
-vhost_user=""
+vhost_user="no"
vhost_user_blk_server="auto"
vhost_user_fs=""
kvm="auto"
@@ -718,7 +718,6 @@ fi
case $targetos in
MINGW32*)
mingw32="yes"
- vhost_user="no"
audio_possible_drivers="dsound sdl"
if check_include dsound.h; then
audio_drv_list="dsound"
@@ -797,6 +796,7 @@ Linux)
audio_possible_drivers="oss alsa sdl pa"
linux="yes"
linux_user="yes"
+ vhost_user="yes"
;;
esac
@@ -2341,9 +2341,8 @@ fi
# vhost interdependencies and host support
# vhost backends
-test "$vhost_user" = "" && vhost_user=yes
-if test "$vhost_user" = "yes" && test "$mingw32" = "yes"; then
- error_exit "vhost-user isn't available on win32"
+if test "$vhost_user" = "yes" && test "$linux" != "yes"; then
+ error_exit "vhost-user is only available on Linux"
fi
test "$vhost_vdpa" = "" && vhost_vdpa=$linux
if test "$vhost_vdpa" = "yes" && test "$linux" != "yes"; then
--
MST
- [PULL 07/17] tests/qtest: add multi-queue test case to vhost-user-blk-test, (continued)
- [PULL 07/17] tests/qtest: add multi-queue test case to vhost-user-blk-test, Michael S. Tsirkin, 2020/11/15
- [PULL 08/17] libqtest: add qtest_socket_server(), Michael S. Tsirkin, 2020/11/15
- [PULL 06/17] test: new qTest case to test the vhost-user-blk-server, Michael S. Tsirkin, 2020/11/15
- [PULL 09/17] vhost-user-blk-test: rename destroy_drive() to destroy_file(), Michael S. Tsirkin, 2020/11/15
- [PULL 11/17] vhost-user-blk-test: drop unused return value, Michael S. Tsirkin, 2020/11/15
- [PULL 12/17] vhost-user-blk-test: fix races by using fd passing, Michael S. Tsirkin, 2020/11/15
- [PULL 13/17] block/export: port virtio-blk discard/write zeroes input validation, Michael S. Tsirkin, 2020/11/15
- [PULL 14/17] vhost-user-blk-test: test discard/write zeroes invalid inputs, Michael S. Tsirkin, 2020/11/15
- [PULL 15/17] block/export: port virtio-blk read/write range check, Michael S. Tsirkin, 2020/11/15
- [PULL 16/17] contrib/libvhost-user: Fix bad printf format specifiers, Michael S. Tsirkin, 2020/11/15
- [PULL 04/17] configure: mark vhost-user Linux-only,
Michael S. Tsirkin <=
- [PULL 10/17] vhost-user-blk-test: close fork child file descriptors, Michael S. Tsirkin, 2020/11/15
- [PULL 17/17] vhost-user-blk/scsi: Fix broken error handling for socket call, Michael S. Tsirkin, 2020/11/15
- Re: [PULL 00/17] pc,vhost: fixes, new test, Peter Maydell, 2020/11/16