qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.2 1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-codi


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-5.2 1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-coding registry.gitlab.com
Date: Mon, 16 Nov 2020 12:59:09 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 11/13/20 6:25 PM, Rebecca Cran wrote:
> Update containers.yml to use the $CI_REGISTRY variable as other files
> such as edk2.yml do.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  .gitlab-ci.d/containers.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
> index 11d079ea5810..892ca8d838ce 100644
> --- a/.gitlab-ci.d/containers.yml
> +++ b/.gitlab-ci.d/containers.yml
> @@ -8,7 +8,7 @@
>      - export COMMON_TAG="$CI_REGISTRY/qemu-project/qemu/$NAME:latest"
>      - apk add python3
>      - docker info
> -    - docker login registry.gitlab.com -u "$CI_REGISTRY_USER" -p 
> "$CI_REGISTRY_PASSWORD"
> +    - docker login $CI_REGISTRY -u "$CI_REGISTRY_USER" -p 
> "$CI_REGISTRY_PASSWORD"
>    script:
>      - echo "TAG:$TAG"
>      - echo "COMMON_TAG:$COMMON_TAG"
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]