[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/11] gitlab-ci: Move artifacts expiry rule to common 'na
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 11/11] gitlab-ci: Move artifacts expiry rule to common 'native_build_job' |
Date: |
Mon, 16 Nov 2020 14:01:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/9/20 10:59 AM, Thomas Huth wrote:
> On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
>> Build jobs include the 'native_build_job' template. Move
>> the 'artifacts expiry' rule there. Now all build jobs benefit
>> from it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> .gitlab-ci.yml | 24 ++++--------------------
>> 1 file changed, 4 insertions(+), 20 deletions(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index dd5f9a4c505..27a4cbc5171 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -79,6 +79,10 @@ include:
>> then
>> make -j"$JOBS" $MAKE_CHECK_ARGS ;
>> fi
>> + artifacts:
>> + expire_in: 2 days
>> + paths:
>> + - build
>
> Should we also keep artifacts for pipelines that do not need it to pass them
> from one job to the next? ... not sure ... considering that gitlab is
> thinking about cutting down CI minutes etc., we should maybe be more
> conservative and only keep artifacts where they are really needed?
As nothing is released from these jobs (except some roms/ and
documentation?) I'd not keep anything at this point. Later we
can be stricter and select the minimum we need.
(I don't think nobody ever downloaded a job artifact to test /
debug it).
>
> Thomas
>
- Re: [PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job', (continued)