[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category |
Date: |
Mon, 16 Nov 2020 15:04:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/15/20 7:48 PM, Gan Qixin wrote:
> The category of the u2f-passthru device is not set, put it into the 'usb'
> category.
I guess we discussed this with Thomas 1 or 2 years ago
but I don't remember. I think it was about using set_bits()
so devices can appear in multiple categories.
Gerd, do you know what is the point of the "usb" category for
management apps? This is a bus accepting multiple better
categorized devices (display, storage, input, network, sound).
Unrelated but multiple devices are related to SECURITY.
Maybe it is time to introduce the DEVICE_CATEGORY_SECURITY?
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/u2f-passthru.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/usb/u2f-passthru.c b/hw/usb/u2f-passthru.c
> index ae00e93f35..000822f396 100644
> --- a/hw/usb/u2f-passthru.c
> +++ b/hw/usb/u2f-passthru.c
> @@ -534,6 +534,7 @@ static void u2f_passthru_class_init(ObjectClass *klass,
> void *data)
> dc->desc = "QEMU U2F passthrough key";
> dc->vmsd = &u2f_passthru_vmstate;
> device_class_set_props(dc, u2f_passthru_properties);
> + set_bit(DEVICE_CATEGORY_USB, dc->categories);
> }
>
> static const TypeInfo u2f_key_passthru_info = {
>
- [PATCH 01/13] pc-dimm: put it into the 'storage' category, (continued)
- [PATCH 01/13] pc-dimm: put it into the 'storage' category, Gan Qixin, 2020/11/16
- [PATCH 05/13] mc146818rtc: put it into the 'misc' category, Gan Qixin, 2020/11/16
- [PATCH 03/13] vmmouse: put it into the 'input' category, Gan Qixin, 2020/11/16
- [PATCH 04/13] nvdimm: put it into the 'storage' category, Gan Qixin, 2020/11/16
- [PATCH 06/13] ipmi: put some ipmi devices into the correct category, Gan Qixin, 2020/11/16
- [PATCH 08/13] AMDVI-PCI: put it into the 'misc' category, Gan Qixin, 2020/11/16
- [PATCH 07/13] tpm: put some tpm devices into the correct category, Gan Qixin, 2020/11/16
- [PATCH 02/13] virtio-pmem: put it into the 'storage' category, Gan Qixin, 2020/11/16
- [PATCH 09/13] u2f-passthru: put it into the 'usb' category, Gan Qixin, 2020/11/16
- [PATCH 12/13] SPI flash devices: put them into the 'storage' category, Gan Qixin, 2020/11/16
- [PATCH 11/13] spitz: put some Spitz-family devices into the correct category, Gan Qixin, 2020/11/16
- [PATCH 10/13] tosa-ssp: put it into the 'misc' category, Gan Qixin, 2020/11/16
- [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Gan Qixin, 2020/11/16