[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue |
Date: |
Tue, 17 Nov 2020 13:01:15 +0100 |
Fix an endianness issue reported by Cornelia:
> s390x tcg guest on x86, virtio-pci devices are not detected. The
> relevant feature bits are visible to the guest. Same breakage with
> different guest kernels.
> KVM guests and s390x tcg guests on s390x are fine.
Fixes: 28dc86a0729 ("s390x/pci: use a PCI Group structure")
Reported-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
RFC because review-only patch, untested
---
hw/s390x/s390-pci-inst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 58cd041d17f..cfb54b4d8ec 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -305,7 +305,7 @@ int clp_service_call(S390CPU *cpu, uint8_t r2, uintptr_t ra)
ClpReqQueryPciGrp *reqgrp = (ClpReqQueryPciGrp *)reqh;
S390PCIGroup *group;
- group = s390_group_find(reqgrp->g);
+ group = s390_group_find(ldl_p(&reqgrp->g));
if (!group) {
/* We do not allow access to unknown groups */
/* The group must have been obtained with a vfio device */
--
2.26.2
- [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue,
Philippe Mathieu-Daudé <=
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Cornelia Huck, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Peter Maydell, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Philippe Mathieu-Daudé, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Pierre Morel, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Cornelia Huck, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Matthew Rosato, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Cornelia Huck, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Matthew Rosato, 2020/11/17
- Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue, Cornelia Huck, 2020/11/17