[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v3 26/32] s390x/pci: use a PCI Group structure
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL v3 26/32] s390x/pci: use a PCI Group structure |
Date: |
Tue, 17 Nov 2020 13:09:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/17/20 1:06 PM, Cornelia Huck wrote:
> On Tue, 17 Nov 2020 12:55:22 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
>> On 11/17/20 12:43 PM, Cornelia Huck wrote:
>>> On Sun, 01 Nov 2020 14:02:46 -0700
>>> Alex Williamson <alex.williamson@redhat.com> wrote:
>>>
>>>> From: Pierre Morel <pmorel@linux.ibm.com>
>>>>
>>>> We use a S390PCIGroup structure to hold the information related to a
>>>> zPCI Function group.
>>>>
>>>> This allows us to be ready to support multiple groups and to retrieve
>>>> the group information from the host.
>>>>
>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>>> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
>>>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>>>> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
>>>> ---
>>>> hw/s390x/s390-pci-bus.c | 42
>>>> +++++++++++++++++++++++++++++++++++++++
>>>> hw/s390x/s390-pci-inst.c | 23 +++++++++++++--------
>>>> include/hw/s390x/s390-pci-bus.h | 10 +++++++++
>>>> 3 files changed, 66 insertions(+), 9 deletions(-)
>>>
>>> I just bisected a regression down to this commit.
>>>
>>> s390x tcg guest on x86, virtio-pci devices are not detected. The
>>> relevant feature bits are visible to the guest. Same breakage with
>>> different guest kernels.
>>>
>>> KVM guests and s390x tcg guests on s390x are fine, so I assume an
>>> endianness issue somewhere. Nothing jumps out to me, though.
>
> (...)
>>>> case CLP_QUERY_PCI_FNGRP: {
>>>> ClpRspQueryPciGrp *resgrp = (ClpRspQueryPciGrp *)resh;
>>>> - resgrp->fr = 1;
>>>> - stq_p(&resgrp->dasm, 0);
>>>> - stq_p(&resgrp->msia, ZPCI_MSI_ADDR);
>>>> - stw_p(&resgrp->mui, DEFAULT_MUI);
>>>> - stw_p(&resgrp->i, 128);
>>>> - stw_p(&resgrp->maxstbl, 128);
>>>> - resgrp->version = 0;
>>>>
>>>> + ClpReqQueryPciGrp *reqgrp = (ClpReqQueryPciGrp *)reqh;
>>>> + S390PCIGroup *group;
>>>> +
>>>> + group = s390_group_find(reqgrp->g);
>>
>> - group = s390_group_find(reqgrp->g);
>> + group = s390_group_find(ldl_p(&reqgrp->g));
>
> Yep, that's it :)
>
> Do you want to send a proper patch, or should I do it?
Sent 5min ago ;)
Regards,
Phil.
- Re: [PULL v3 23/32] s390x/pci: Add routine to get the vfio dma available count, (continued)
[PULL v3 24/32] s390x/pci: Honor DMA limits set by vfio, Alex Williamson, 2020/11/01
[PULL v3 26/32] s390x/pci: use a PCI Group structure, Alex Williamson, 2020/11/01
[PULL v3 25/32] s390x/pci: create a header dedicated to PCI CLP, Alex Williamson, 2020/11/01
[PULL v3 27/32] s390x/pci: clean up s390 PCI groups, Alex Williamson, 2020/11/01
[PULL v3 28/32] s390x/pci: use a PCI Function structure, Alex Williamson, 2020/11/01
[PULL v3 29/32] vfio: Add routine for finding VFIO_DEVICE_GET_INFO capabilities, Alex Williamson, 2020/11/01
[PULL v3 30/32] s390x/pci: get zPCI function info from host, Alex Williamson, 2020/11/01
[PULL v3 31/32] hw/vfio: Use lock guard macros, Alex Williamson, 2020/11/01
[PULL v3 32/32] vfio: fix incorrect print type, Alex Williamson, 2020/11/01
Re: [PULL v3 00/32] VFIO updates 2020-11-01 (for QEMU 5.2 soft-freeze), Peter Maydell, 2020/11/02