[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/7] quorum: Require WRITE perm with rewrite-corrupted
From: |
Kevin Wolf |
Subject: |
[PULL 5/7] quorum: Require WRITE perm with rewrite-corrupted |
Date: |
Tue, 17 Nov 2020 13:15:56 +0100 |
From: Max Reitz <mreitz@redhat.com>
Using rewrite-corrupted means quorum may issue writes to its children
just from receiving read requests from its parents. Thus, it must take
the WRITE permission when rewrite-corrupted is used.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20201113211718.261671-2-mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/quorum.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index e846a7e892..b10fc2089e 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -1163,7 +1163,12 @@ static void quorum_child_perm(BlockDriverState *bs,
BdrvChild *c,
uint64_t perm, uint64_t shared,
uint64_t *nperm, uint64_t *nshared)
{
+ BDRVQuorumState *s = bs->opaque;
+
*nperm = perm & DEFAULT_PERM_PASSTHROUGH;
+ if (s->rewrite_corrupted) {
+ *nperm |= BLK_PERM_WRITE;
+ }
/*
* We cannot share RESIZE or WRITE, as this would make the
--
2.28.0
- [PULL 0/7] Patches for 5.2.0-rc2, Kevin Wolf, 2020/11/17
- [PULL 1/7] char-stdio: Fix QMP default for 'signal', Kevin Wolf, 2020/11/17
- [PULL 2/7] iotests: Replace deprecated ConfigParser.readfp(), Kevin Wolf, 2020/11/17
- [PULL 4/7] io_uring: do not use pointer after free, Kevin Wolf, 2020/11/17
- [PULL 3/7] file-posix: allow -EBUSY errors during write zeros on raw block devices, Kevin Wolf, 2020/11/17
- [PULL 5/7] quorum: Require WRITE perm with rewrite-corrupted,
Kevin Wolf <=
- [PULL 6/7] iotests/081: Filter image format after testdir, Kevin Wolf, 2020/11/17
- [PULL 7/7] iotests/081: Test rewrite-corrupted without WRITE, Kevin Wolf, 2020/11/17
- Re: [PULL 0/7] Patches for 5.2.0-rc2, Peter Maydell, 2020/11/17