[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/7] qapi: Introduce QAPI_LIST_APPEND
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 5/7] qapi: Introduce QAPI_LIST_APPEND |
Date: |
Tue, 17 Nov 2020 18:41:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/17/20 6:51 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
>> Similar to the existing QAPI_LIST_PREPEND, but designed for use where
>> we want to preserve insertion order. Callers will be added in
>> upcoming patches. Note the difference in signature: PREPEND takes
>> List*, APPEND takes List**.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> +#define QAPI_LIST_APPEND(tail, element) do { \
>> + *(tail) = g_malloc0(sizeof(**(tail))); \
>> + (*(tail))->value = (element); \
>> + (tail) = &(*tail)->next; \
Hmm; I'm inconsistent on whether to spell things '*tail' or '*(tail)'.
I don't think any of the callers converted in patches 6 or 7 care about
the difference, but for maximal copy-paste portability, the use of the
macro parameter should be surrounded by () anywhere that could otherwise
cause a mis-parse on some arbitrary expression with an operator at
higher precedence than unary * (hmm, the only such operators are all
suffix operators; so maybe the *(tail) is overkill...)
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v2 0/7] Common macros for QAPI list growth, Eric Blake, 2020/11/12
- [PATCH v2 4/7] qapi: Use QAPI_LIST_PREPEND() where possible, Eric Blake, 2020/11/12
- [PATCH v2 6/7] qapi: Use QAPI_LIST_APPEND in trivial cases, Eric Blake, 2020/11/12
- [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND, Eric Blake, 2020/11/12
- Re: [PATCH v2 0/7] Common macros for QAPI list growth, Markus Armbruster, 2020/11/19