Re: [PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

[no-reply]

Patchew URL: 20201119060833.25328-1-lma@suse.com/">https://patchew.org/QEMU/20201119060833.25328-1-lma@suse.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201119060833.25328-1-lma@suse.com
Subject: [PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201119060833.25328-1-lma@suse.com -> 
patchew/20201119060833.25328-1-lma@suse.com
Switched to a new branch 'test'
1dd28de qga: Correct loop count in qmp_guest_get_vcpus()

=== OUTPUT BEGIN ===
ERROR: else should follow close brace '}'
#91: FILE: qga/commands-posix.c:2494:
         }
+        else

ERROR: braces {} are necessary even for single statement blocks
#91: FILE: qga/commands-posix.c:2494:
+        else
+            max_loop_count += 1;

total: 2 errors, 0 warnings, 26 lines checked

Commit 1dd28de20dce (qga: Correct loop count in qmp_guest_get_vcpus()) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201119060833.25328-1-lma@suse.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201119060833.25328-1-lma@suse.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com