[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2 v2] trace: use STAP_SDT_V2 to work around symbol visi
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH-for-5.2 v2] trace: use STAP_SDT_V2 to work around symbol visibility |
Date: |
Thu, 19 Nov 2020 11:58:51 +0000 |
On Thu, Nov 19, 2020 at 11:45 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
> On 11/19/20 12:27 PM, Stefan Hajnoczi wrote:
> > diff --git a/configure b/configure
> > index 714e75b5d8..5d91d49c7b 100755
> > --- a/configure
> > +++ b/configure
> > @@ -4832,6 +4832,7 @@ if have_backend "dtrace"; then
> > trace_backend_stap="no"
> > if has 'stap' ; then
> > trace_backend_stap="yes"
>
> Maybe add a comment? (no need to repost if you agree):
>
> # Workaround to avoid dtrace(1) produces file with 'hidden'
> # symbol visibility, define STAP_SDT_V2 to produce 'default'
> # symbol visibility instead.
>
> > + QEMU_CFLAGS="$QEMU_CFLAGS -DSTAP_SDT_V2"
Yes, that would be helpful.
Stefan