Re: [PATCH V13 2/9] meson.build: Re-enable KVM support for MIPS

[Huacai Chen]

Hi, Philippe,

On Wed, Nov 18, 2020 at 1:17 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Hi Huacai,
>
> On 10/7/20 10:39 AM, Huacai Chen wrote:
> > After converting from configure to meson, KVM support is lost for MIPS,
> > so re-enable it in meson.build.
> >
> > Fixes: fdb75aeff7c212e1afaaa3a43 ("configure: remove target configuration")
> > Fixes: 8a19980e3fc42239aae054bc9 ("configure: move accelerator logic to 
> > meson")
> > Cc: aolo Bonzini <pbonzini@redhat.com>
> > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > ---
> >  meson.build | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meson.build b/meson.build
> > index 17c89c8..b407ff4 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -59,6 +59,8 @@ elif cpu == 's390x'
> >    kvm_targets = ['s390x-softmmu']
> >  elif cpu in ['ppc', 'ppc64']
> >    kvm_targets = ['ppc-softmmu', 'ppc64-softmmu']
> > +elif cpu in ['mips', 'mips64']
> > +  kvm_targets = ['mips-softmmu', 'mipsel-softmmu', 'mips64-softmmu', 
> > 'mips64el-softmmu']
>
> Are you sure both 32-bit hosts and targets are supported?
>
> I don't have hardware to test. If you are not working with
> 32-bit hardware I'd remove them.
When I add MIPS64 KVM support (Loongson-3 is MIPS64), MIPS32 KVM is
already there. On the kernel side, MIPS32 KVM is supported, but I
don't know whether it can work well.

Huacai

>
> >  else
> >    kvm_targets = []
> >  endif
> >