[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2] Revert "hw/core/qdev-properties: Use qemu_strtoul()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH for-5.2] Revert "hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()" |
Date: |
Fri, 20 Nov 2020 14:49:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/20/20 2:04 PM, Michael S. Tsirkin wrote:
> This reverts commit bccb20c49df1bd683248a366021973901c11982f as it
> introduced a regression blocking bus addresses > 0x1f or higher.
> Legal bus numbers go up to 0xff.
>
> Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
> Fixes: bccb20c49df ("Use qemu_strtoul() in set_pci_host_devaddr()")
> Reported-by: Klaus Herman <kherman@inbox.lv>
> Reported-by: Geoffrey McRae <geoff@hostfission.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> checkpatch will complain since it does not like strtoul but
> we had it for years so should be ok for 5.2, right?
>
> hw/core/qdev-properties-system.c | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
Thanks!
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>