qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 00/37] cleanup qemu_init and make sense of command lin


From: Paolo Bonzini
Subject: Re: [RFC PATCH v2 00/37] cleanup qemu_init and make sense of command line processing
Date: Fri, 20 Nov 2020 17:27:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 20/11/20 17:19, Igor Mammedov wrote:
On Tue, 3 Nov 2020 15:37:13 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

On 03/11/20 13:57, Igor Mammedov wrote:
It's based on 20201026143028.3034018-1-pbonzini@redhat.com (which you
should be able to get through patchew).
Not sure what you mean and how to do that.
Is it possible to share v2 as a git tree somewhere?

I pushed it to for-6.0 on my gitlab repo.  There's a lot more stuff in
the branch, but these patches are at the top.

had to use temporary fixup, to make build pass and fix '-device help' crash
with your branch. (upstream master doesn't have this problem)

diff --git a/util/qemu-option.c b/util/qemu-option.c
index 858860377b..78f3397736 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -776,6 +776,7 @@ static const char *get_opt_name_value(const char *params,
          /* found "foo,more" */
          if (help_wanted && starts_with_help_option(params) == len) {
              *help_wanted = true;
+            return NULL;
          } else if (firstname) {
              /* implicitly named first option */
              *name = g_strdup(firstname);

Thanks!  I'll integrate this in the right place of the series.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]