Re: [RFC PATCH v5 20/33] Hexagon (target/hexagon) generator phase 2 - generate header files

[Alessandro Di Federico]

On Thu, 29 Oct 2020 19:08:26 -0500
Taylor Simpson <tsimpson@quicinc.com> wrote:

> +def genptr_decl_new(f,regtype,regid,regno):
> +    if (regtype == "N"):
> +        if (regid in {"s", "t"}):
> +            f.write("    const int %s%sX = insn->regno[%d];\n" % \
> +                (regtype, regid, regno))
> +            f.write("    TCGv %s%sN = tcg_const_tl(%s%sX);\n" % \
> +                (regtype, regid, regtype, regid))

This part is a bit incoherent with all the rest.
You're creating a TCGv containing a constant representing the register
number. Why not just create a TCGv with the value of the register
itself as you usually do?

-- 
Alessandro Di Federico
rev.ng