[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/5] tap: fix a memory leak
From: |
Jason Wang |
Subject: |
[PULL 4/5] tap: fix a memory leak |
Date: |
Tue, 24 Nov 2020 10:44:22 +0800 |
From: yuanjungong <ruc_gongyuanjun@163.com>
Close fd before returning.
Buglink: https://bugs.launchpad.net/qemu/+bug/1904486
Signed-off-by: yuanjungong <ruc_gongyuanjun@163.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/tap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/tap.c b/net/tap.c
index c46ff66..fe95fa7 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -817,6 +817,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
if (ret < 0) {
error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
name, fd);
+ close(fd);
return -1;
}
@@ -831,6 +832,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
vhostfdname, vnet_hdr, fd, &err);
if (err) {
error_propagate(errp, err);
+ close(fd);
return -1;
}
} else if (tap->has_fds) {
--
2.7.4
- [PULL 0/5] Net patches, Jason Wang, 2020/11/23
- [PULL 1/5] hw/net/e1000e: advance desc_offset in case of null descriptor, Jason Wang, 2020/11/23
- [PULL 2/5] net: do not exit on "netdev_add help" monitor command, Jason Wang, 2020/11/23
- [PULL 3/5] net: purge queued rx packets on queue deletion, Jason Wang, 2020/11/23
- [PULL 4/5] tap: fix a memory leak,
Jason Wang <=
- [PULL 5/5] net: Use correct default-path macro for downscript, Jason Wang, 2020/11/23
- Re: [PULL 0/5] Net patches, Peter Maydell, 2020/11/24