Re: [PATCH v2] Fix build with 64 bits time_t

[Fabrice Fontaine]

Le mer. 25 nov. 2020 à 13:06, Gerd Hoffmann <kraxel@redhat.com> a écrit :
>
> On Wed, Nov 18, 2020 at 09:38:24PM +0100, Fabrice Fontaine wrote:
> > time element is deprecated on new input_event structure in kernel's
> > input.h [1]
> >
> > This will avoid the following build failure:
> >
> > hw/input/virtio-input-host.c: In function 'virtio_input_host_handle_status':
> > hw/input/virtio-input-host.c:198:28: error: 'struct input_event' has no 
> > member named 'time'
> >   198 |     if (gettimeofday(&evdev.time, NULL)) {
> >       |                            ^
>
> Fails to build (rhel-7).
>
> >  - Drop define of input_event_{sec,usec} as it is already done in
> >    include/standard-headers/linux/input.h
>
> Maybe these are not used?  So it breaks with old system headers?
contrib/vhost-user-input/main.c is including <linux/input.h> instead
of ./include/standard-headers/linux/input.h, this could be the root
cause. I'll send a v3.
>
> take care,
>   Gerd
>
Best Regards,

Fabrice