Re: [PATCH v2 00/13] Remove GCC < 4.8 checks

[no-reply]

Patchew URL: 
20201126112915.525285-1-marcandre.lureau@redhat.com/">https://patchew.org/QEMU/20201126112915.525285-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201126112915.525285-1-marcandre.lureau@redhat.com
Subject: [PATCH v2 00/13] Remove GCC < 4.8 checks

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201125185551.20475-1-berto@igalia.com -> 
patchew/20201125185551.20475-1-berto@igalia.com
 * [new tag]         
patchew/20201126112915.525285-1-marcandre.lureau@redhat.com -> 
patchew/20201126112915.525285-1-marcandre.lureau@redhat.com
Switched to a new branch 'test'
77ab4c6 linux-user: remove GNUC check
f76a0b9 compiler: remove GNUC check
beeadb1 xen: remove GNUC check
405e99f poison: remove GNUC check
e5c6d98 audio: remove GNUC & MSVC check
2678b63 compiler.h: explicit case for Clang printf attribute
47e1c5e virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON
5e15c4d tests: remove GCC < 4 fallbacks
a2ff6e8 qemu-plugin.h: remove GCC < 4
f0eebeb compiler.h: remove GCC < 3 __builtin_expect fallback
b157e9f accel/tcg: Remove special case for GCC < 4.6
93edd26 qemu/atomic: Drop special case for unsupported compiler
b5c4061 compiler.h: replace QEMU_GNUC_PREREQ macro

=== OUTPUT BEGIN ===
1/13 Checking commit b5c4061785ec (compiler.h: replace QEMU_GNUC_PREREQ macro)
WARNING: architecture specific defines should be avoided
#25: FILE: accel/tcg/cpu-exec.c:727:
+#if defined(__clang__) || !G_GNUC_CHECK_VERSION(4, 6)

total: 0 errors, 1 warnings, 54 lines checked

Patch 1/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/13 Checking commit 93edd26cd83a (qemu/atomic: Drop special case for 
unsupported compiler)
3/13 Checking commit b157e9f1f2df (accel/tcg: Remove special case for GCC < 4.6)
WARNING: architecture specific defines should be avoided
#30: FILE: accel/tcg/cpu-exec.c:727:
+#if defined(__clang__)

total: 0 errors, 1 warnings, 8 lines checked

Patch 3/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/13 Checking commit f0eebebebb3b (compiler.h: remove GCC < 3 __builtin_expect 
fallback)
5/13 Checking commit a2ff6e8ca3d5 (qemu-plugin.h: remove GCC < 4)
6/13 Checking commit 5e15c4d002dd (tests: remove GCC < 4 fallbacks)
ERROR: space prohibited between function name and open parenthesis '('
#28: FILE: tests/tcg/arm/fcvt.c:76:
+# define SNANF (__builtin_nansf (""))

ERROR: space prohibited between function name and open parenthesis '('
#29: FILE: tests/tcg/arm/fcvt.c:77:
+# define SNAN (__builtin_nans (""))

ERROR: space prohibited between function name and open parenthesis '('
#30: FILE: tests/tcg/arm/fcvt.c:78:
+# define SNANL (__builtin_nansl (""))

total: 3 errors, 0 warnings, 14 lines checked

Patch 6/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/13 Checking commit 47e1c5e0319a (virtiofsd: replace _Static_assert with 
QEMU_BUILD_BUG_ON)
8/13 Checking commit 2678b639f490 (compiler.h: explicit case for Clang printf 
attribute)
WARNING: architecture specific defines should be avoided
#37: FILE: include/qemu/compiler.h:93:
+#if defined(__clang__)

WARNING: Block comments use a leading /* on a separate line
#44: FILE: include/qemu/compiler.h:100:
+   /* Map __printf__ to __gnu_printf__ because we want standard format strings

WARNING: Block comments use a trailing */ on a separate line
#45: FILE: include/qemu/compiler.h:101:
+    * even when MinGW or GLib include files use __printf__. */

total: 0 errors, 3 warnings, 28 lines checked

Patch 8/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/13 Checking commit e5c6d9859362 (audio: remove GNUC & MSVC check)
10/13 Checking commit 405e99fe1fee (poison: remove GNUC check)
11/13 Checking commit beeadb186e66 (xen: remove GNUC check)
12/13 Checking commit f76a0b946371 (compiler: remove GNUC check)
13/13 Checking commit 77ab4c6a10d7 (linux-user: remove GNUC check)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201126112915.525285-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201126112915.525285-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com